This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/766/2/tests/rlcmac/RLCMACTest.cpp
File tests/rlcmac/RLCMACTest.cpp:
Line 33: extern "C" {
Like with 703, this is clearly not based on 765.
Something in your workflow is causing bogus history in your patch submissions.
If you have your patch series on a local branch (or on local master, for that matter),
all you need is to be on the last commit and do
git push origin HEAD:refs/for/master
or if you like to add a topic
git push origin HEAD:refs/for/master/my_topic_name
This way both commits are pushed to gerrit at the
same time, and they are guaranteed to match up.
The above is assuming that you have cloned the git repos
from the gerrit git, see
http://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit#Simplest-new-clone
I would be interested to know why this problem is possible.
How exactly do you push a patch for review?
--
To view, visit https://gerrit.osmocom.org/766
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieddf96aca82b0b0e917cfcc70aeb978799fb4e95
Gerrit-PatchSet: 2
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-HasComments: Yes