This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 4: (2 comments) https://gerrit.osmocom.org/#/c/431/4/src/encoding.cpp File src/encoding.cpp: Line 22: #include <bts.h> > It is necessary to move #include. Otherwise compilation will break. No, that's not how this works. If you need a definition in encoding.h, you add the corresponding #include to encoding.h, you absolutely do not start tweaking the order of including headers in the .cpp files. Undo these moves and add the needed header to encoding.h. https://gerrit.osmocom.org/#/c/431/4/src/encoding.h File src/encoding.h: Line 26: Add this here to be able to use enum ph_burst_type: extern "C" { #include <osmocom/gsm/l1sap.h> } (I have verified that this works) -- To view, visit https://gerrit.osmocom.org/431 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie5e309156e5dbbb6add74a1b4d257c4ee2332e52 Gerrit-PatchSet: 4 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: bhargava_abhyankar <Bhargava.Abhyankar at radisys.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: bhargava_abhyankar <Bhargava.Abhyankar at radisys.com> Gerrit-HasComments: Yes