osmo-pcu[master]: EGPRS: PUAN encoding: add test case to show wrong urbb_len i...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Aug 23 15:58:15 UTC 2016


Patch Set 10:

> May be in future with some addition of new field in the PUAN message
> it can generate some other hex stream. which may cause issue with
> this test case.

That is the idea of a test case: if you change the code, your test
suite should notice that. Adjusting test expectations is expected
and desired with code moving forward.

If the data is indeed generated by e.g. a kernel module or an
external library, it doesn't make sense to test specific bytes here.
But AFAICT this data is generated in osmo-pcu code, so let's check it.

-- 
To view, visit https://gerrit.osmocom.org/702
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00662a564f64c0c83627401ae8f7bfef0f0a5de8
Gerrit-PatchSet: 10
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-HasComments: No



More information about the gerrit-log mailing list