osmo-pcu[master]: EGPRS: PUAN encoding: add test case to show wrong urbb_len i...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Aug 23 15:53:56 UTC 2016


Patch Set 10:

(1 comment)

https://gerrit.osmocom.org/#/c/702/10/tests/tbf/TbfTest.cpp
File tests/tbf/TbfTest.cpp:

Line 753: 	OSMO_ASSERT(!memcmp(msg2->data, msg1->data, msg1->data_len));
> Hi Neels,
I must admit I'm not familiar enough to know for certain, but
all I see is the data that is tested here being generated in
encoding.c in the osmo-pcu source tree ("bitvec_write_field...").

Please confirm that some external entity generates the PUAN
(an external library?), and point me at the code that calls
it, please.


-- 
To view, visit https://gerrit.osmocom.org/702
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00662a564f64c0c83627401ae8f7bfef0f0a5de8
Gerrit-PatchSet: 10
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list