This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
arvind.sirsikar gerrit-no-reply at lists.osmocom.orgPatch Set 10: (1 comment) https://gerrit.osmocom.org/#/c/702/10/tests/tbf/TbfTest.cpp File tests/tbf/TbfTest.cpp: Line 753: OSMO_ASSERT(!memcmp(msg2->data, msg1->data, msg1->data_len)); > This tests for identity (when fixed non-identity) of two messages. Hi Neels, As the generated PUAN is not under our control it is not advisable to compare with pattern like "01 02 03 04....". May be in future with some addition of new field in the PUAN message it can generate some other hex stream. which may cause issue with this test case. Please suggest. Thanks, Aravind Sirsikar -- To view, visit https://gerrit.osmocom.org/702 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00662a564f64c0c83627401ae8f7bfef0f0a5de8 Gerrit-PatchSet: 10 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-HasComments: Yes