osmo-pcu[master]: EGPRS: PUAN encoding: add test case to show wrong urbb_len i...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Aug 23 11:05:58 UTC 2016


Patch Set 7:

(3 comments)

https://gerrit.osmocom.org/#/c/702/7//COMMIT_MSG
Commit Message:

Line 13: AddS test_tbf_puan_urbb_len to describe the following bug:
It's nice that you accept my text, but indeed the test case has a different name. Either rename the test case or use the correct name here.

("AddS" looks like a typo)


Line 17: "Related: OS#1793"
ah, no quotes around it, then it's perfect.


https://gerrit.osmocom.org/#/c/702/7/tests/tbf/TbfTest.cpp
File tests/tbf/TbfTest.cpp:

Line 1771: static void test_tbf_puan_issue(void)
...this name. As suggested in the commit log, IMHO "puan_issue"
is too general. There may be more PUAN issues coming up
in the future (or the past).


-- 
To view, visit https://gerrit.osmocom.org/702
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00662a564f64c0c83627401ae8f7bfef0f0a5de8
Gerrit-PatchSet: 7
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list