This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 21: (4 comments) https://gerrit.osmocom.org/#/c/655/21//COMMIT_MSG Commit Message: Line 10: Retx. This patch will also Upgrade the test suite with test cases hm, was about to +2, but I don't see the test cases this commit log is talking about? Drop the "Upgrade" sentence? https://gerrit.osmocom.org/#/c/655/21/src/pcu_vty.c File src/pcu_vty.c: Line 133: vty_out(vty, " egprs dl arq-type %s%s", "arq2", hehe interesting -- at first I thought you had forgot to check for spb, but since spb is the default you only need to print something if arq2 is enabled. It doesn't really make sense to do "foo %s", "bar" i.e. rather have "... arq-type arq2%s", VTY_NEWLINE but whatever. Line 487: #define DL_STR "DL specific configuration\n" I'd prefer "DL" written out in the doc, noob users will have an easier time understanding what it means then. leaving it up to you. What does it mean, "downlink"? Line 494: "enable ARQ2 support") nice. -- To view, visit https://gerrit.osmocom.org/655 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I242afdd8ae7622dec8593b26382ad66bad5b9516 Gerrit-PatchSet: 21 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-HasComments: Yes