This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Holger Freyther gerrit-no-reply at lists.osmocom.orgPatch Set 18: (10 comments) https://gerrit.osmocom.org/#/c/416/18/src/egprs_rlc_compression.cpp File src/egprs_rlc_compression.cpp: Line 17: Node *egprs_compress::create_tree_node() ::create_tree_node(void *parent) PS18, Line 21: talloc_zero talloc_zert(parent, Node) Line 51: iter->left = create_tree_node(); create_tree_node(root) Line 55: iter->right = create_tree_node(); create_tree_node(root) Line 329: tall_tree_ctx = talloc_named_const(tall_pcu_ctx, 0, you can remove.. we will see two trees anyway Line 333: ones_list = talloc(tall_tree_ctx, Node); ones_list = create_tree_node(tall_pcu_ctx); Line 334: zeros_list = talloc(tall_tree_ctx, Node); zeroes_list = create_tree_node(tall_pcu_ctx) https://gerrit.osmocom.org/#/c/416/18/src/egprs_rlc_compression.h File src/egprs_rlc_compression.h: Line 3: */ missing pragma once. Line 27: extern void *tall_pcu_ctx; not needed. https://gerrit.osmocom.org/#/c/416/18/tests/Makefile.am File tests/Makefile.am: Line 38: -Wl,-u,bssgp_prim_cb Still.. the tree code doesn't depend on GB, GSM, etc.. drop that.. drop the linking hack with allowing bssgp_prim_cb to be undefined. -- To view, visit https://gerrit.osmocom.org/416 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieae1992ed4b02bb1e09eec2d3de1a030eabd16ce Gerrit-PatchSet: 18 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: pravin <pravin.manoharan at radisys.com> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: pravin <pravin.manoharan at radisys.com> Gerrit-HasComments: Yes