This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Patch Set 5:
(2 comments)
https://gerrit.osmocom.org/#/c/433/5/src/common/l1sap.c
File src/common/l1sap.c:
Line 969: (trx == bts->c0 && rach_ind->is_11bit)) {
strictly speaking, this change is more than just changing
the interface between bts and pcu. You should mention this
in the commit log (e.g. "Add 11bit rach to the ts_is_pdch()
check in l1sap.c") or move this to the other 11bit commit.
https://gerrit.osmocom.org/#/c/433/5/src/osmo-bts-sysmo/l1_if.c
File src/osmo-bts-sysmo/l1_if.c:
Line 978:
this is the only change in this patch that is for a
specific BTS model. Does that mean the other BTS models
are missing this initialization?
Can this BTS-specific part be moved to the osmo-bts-sysmo specific commit?
--
To view, visit https://gerrit.osmocom.org/433
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f4c501b2d86d77c78de32a84b1804172ffb6f4d
Gerrit-PatchSet: 5
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: bhargava_abhyankar <Bhargava.Abhyankar at radisys.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: bhargava_abhyankar <Bhargava.Abhyankar at radisys.com>
Gerrit-HasComments: Yes