osmo-pcu[master]: Change interface in osmo-pcu for 11 bit RACH

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Sat Aug 20 02:50:20 UTC 2016


Patch Set 4: Code-Review+1

(2 comments)

I've reminded Holger of his -2... looks good to me except cosmetics.

https://gerrit.osmocom.org/#/c/429/4/src/pcuif_proto.h
File src/pcuif_proto.h:

Line 76: 	uint8_t         is_11bit;
(whitespace: the other lines use tab, but the is_11bit line uses spaces between type and member name)


https://gerrit.osmocom.org/#/c/429/4/tests/tbf/TbfTest.cpp
File tests/tbf/TbfTest.cpp:

Line 1094: 	/* simulate RACH, sends an Immediate Assignment Uplink on the AGCH */
(unnecessary change in the comment?)


-- 
To view, visit https://gerrit.osmocom.org/429
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I265c2d92d36d6cbcbeee60cdd8407dafe1da06a4
Gerrit-PatchSet: 4
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: bhargava_abhyankar <Bhargava.Abhyankar at radisys.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: bhargava_abhyankar <Bhargava.Abhyankar at radisys.com>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list