osmo-pcu[master]: Update the function immediate assignment for EGPRS

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Sat Aug 20 02:29:23 UTC 2016


Patch Set 4:

(3 comments)

https://gerrit.osmocom.org/#/c/431/4/src/encoding.cpp
File src/encoding.cpp:

Line 22: #include <bts.h>
is it really necessary to move this #include?


https://gerrit.osmocom.org/#/c/431/4/src/encoding.h
File src/encoding.h:

Line 43: 			bitvec * dest, uint8_t downlink, uint16_t ra,
It is not obvious why this is changed to uint16_t, maybe describe in the commit log?


https://gerrit.osmocom.org/#/c/431/4/tests/edge/EdgeTest.cpp
File tests/edge/EdgeTest.cpp:

Line 43: #include "encoding.h"
is it really necessary to move this #include?

If it is, it should be mentioned in the commit log msg.


-- 
To view, visit https://gerrit.osmocom.org/431
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie5e309156e5dbbb6add74a1b4d257c4ee2332e52
Gerrit-PatchSet: 4
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: bhargava_abhyankar <Bhargava.Abhyankar at radisys.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: bhargava_abhyankar <Bhargava.Abhyankar at radisys.com>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list