osmo-pcu[master]: Describe the issue with EGPRS PUAN encoding

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Sat Aug 20 01:41:39 UTC 2016


Patch Set 1:

> Below patch series is arranged with reference to below mail
 > 
 > http://lists.osmocom.org/pipermail/osmocom-net-gprs/2016-July/000680.html

Indeed, I was going to quote the exact same mail, but must find that I remembered
it wrongly. I thought it said "commit the correct unit test with the fix",
but actually it does say to comment an assert and fix it later.
So let me take back the part of my commentary on line 753.
(I would prefer a real expected-to-fail infrastructure, but we don't have that.)

The other comments are still valid. Most important to me would be an improved
commit log message that has a link to an osmocom.org issue and/or a mail thread
and is easier to understand. It should also say something in the line of:
"add unit test that expects a current bug, to be changed in a subsequent commit
containing the bugfix."

-- 
To view, visit https://gerrit.osmocom.org/702
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00662a564f64c0c83627401ae8f7bfef0f0a5de8
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-HasComments: No



More information about the gerrit-log mailing list