This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
arvind.sirsikar gerrit-no-reply at lists.osmocom.orgPatch Set 17: (4 comments) https://gerrit.osmocom.org/#/c/655/15/src/pcu_vty.c File src/pcu_vty.c: Line 489: "dl arq-type (spb|arq2)", > I notice that 0 is for EGPRS_ARQ1 and 1 is for EGPRS_ARQ2. Done Line 490: EGPRS_STR "DL ARQ options\n" > ah, missed this one before: EGPRS_STR is only for "egprs", not for "dl". Hi Neels, I am not clear on this comment. Currently I get the out put like this in VTY. Osmo-PCU(config-pcu)# dl arq-type spb arq2 Osmo-PCU(config-pcu)# dl arq-type spb enable DL SPB(ARQ1) support arq2 enable DL ARQ2 support Can you please more clear on your comment. Line 491: "enable DL SPB(ARQ1) support\n" > is SPB == ARQ1? I'm not familiar with the topic, but if Done https://gerrit.osmocom.org/#/c/655/15/src/tbf_dl.cpp File src/tbf_dl.cpp: Line 1215: { > this now fits on one line. Done -- To view, visit https://gerrit.osmocom.org/655 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I242afdd8ae7622dec8593b26382ad66bad5b9516 Gerrit-PatchSet: 17 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-HasComments: Yes