[PATCH] cellmgr-ng[master]: mgcp: Address compiler warning and initialize

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Sun Aug 14 06:19:11 UTC 2016


Review at  https://gerrit.osmocom.org/694

mgcp: Address compiler warning and initialize

mgcp/mgcp_protocol.c: In function ‘mgcp_handle_message’:
/home/ich/install/openbsc/include/osmocom/core/logging.h:59:4: warning: ‘save’ may be used uninitialized in this function [-Wmaybe-uninitialized]
    logp2(ss, level, __BASE_FILE__, __LINE__, 0, fmt, ##args); \
    ^
mgcp/mgcp_protocol.c:368:15: note: ‘save’ was declared here
  char *elem, *save;

Change-Id: I28152373b043c8a5b55a83ac09dd7bafce4d2d66
---
M src/mgcp/mgcp_protocol.c
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/cellmgr-ng refs/changes/94/694/1

diff --git a/src/mgcp/mgcp_protocol.c b/src/mgcp/mgcp_protocol.c
index d3561d5..40acc09 100644
--- a/src/mgcp/mgcp_protocol.c
+++ b/src/mgcp/mgcp_protocol.c
@@ -365,7 +365,7 @@
 static int mgcp_analyze_header(struct mgcp_parse_data *pdata, char *data)
 {
 	int i = 0;
-	char *elem, *save;
+	char *elem, *save = NULL;
 
 	pdata->trans = "000000";
 

-- 
To view, visit https://gerrit.osmocom.org/694
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I28152373b043c8a5b55a83ac09dd7bafce4d2d66
Gerrit-PatchSet: 1
Gerrit-Project: cellmgr-ng
Gerrit-Branch: master
Gerrit-Owner: Holger Freyther <holger at freyther.de>



More information about the gerrit-log mailing list