osmo-pcu[master]: jenkins.sh: use absolute paths instead of 'cd ..' and $PWD

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Aug 11 11:05:36 UTC 2016


Patch Set 1:

> Okay, but is there a good reason for it?

My reasons:

1. I find it hard to follow the cwd and what paths like "../install"
   actually mean. With abs path variables, cwd is always clear.

2. When editing, it is easy to forget a "cd .." in the middle, and
   the rest ends up in the wrong dir. With abs path variables, we
   will always be in the right dir.

-- 
To view, visit https://gerrit.osmocom.org/680
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If79d283fa0a559bb7ea319c513d09466eff523d1
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: neels_test_account <neels at hofmeyr.de>
Gerrit-HasComments: No



More information about the gerrit-log mailing list