libosmocore[master]: Add function to send TRAP over Control Interface

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Thu Aug 11 06:16:07 UTC 2016


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/649/1/src/ctrl/control_if.c
File src/ctrl/control_if.c:

Line 126: int ctrl_cmd_send_trap(struct ctrl_handle *ctrl, char *name, char *value)
> I think the problem is that 'struct ctrl_cmd' doesn't define its name and v
With a quick test in libosmocore we can make id, variable, reply const. For reply we need to modify the unused(!!!) get_rate_ctr_group.

General note: API is a lot harder than pushing the first idea into a library. I would like to see interfaces grow in an application and if useful and mature move to the library.


-- 
To view, visit https://gerrit.osmocom.org/649
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0b8d88c4f5c4d42c3f8fb754f8eabf049c9e388
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list