This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Patch Set 7: Code-Review-1
(6 comments)
https://gerrit.osmocom.org/#/c/638/7//COMMIT_MSG
Commit Message:
Line 7: Adding LLC-XID encoder / decoder
"Add [...] and unit test"
https://gerrit.osmocom.org/#/c/638/7/openbsc/include/openbsc/gprs_llc_xid.h
File openbsc/include/openbsc/gprs_llc_xid.h:
Line 53: gprs_llc_xid_field
I'd prefer if you kept each argument within one line,
as in, each line ends with a comma or a ')'.
Instead remove some indenting if you need to for 80 chars width.
https://gerrit.osmocom.org/#/c/638/7/openbsc/tests/xid/xid_test.c
File openbsc/tests/xid/xid_test.c:
Line 111: gprs_llc_dump_xid_fields(xid_fields, DSNDCP);
check output in experr?
Line 113:
(whitespace)
Line 119:
(whitespace)
Line 159
you need to add a stub for bssgp_prim_cb like in sgsn_test.c:
/* stubs */
struct osmo_prim_hdr;
int bssgp_prim_cb(struct osmo_prim_hdr *oph, void *ctx)
{
abort();
}
--
To view, visit https://gerrit.osmocom.org/638
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia06e4cb08bf9b48c2a4682606d1b1a91d19a9d37
Gerrit-PatchSet: 7
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes