osmo-bts[master]: sysmo: fix dyn TS: Revert "Activate PTCCH UL" [in sysmobts]

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Aug 10 15:55:42 UTC 2016


Patch Set 1:

> According to fw docs the only channel combination with PTCCH
 > support is GsmL1_LogChComb_XIII so it's incompatible with dyn
 > channels - see src/osmo-bts-sysmo/oml.c

This has nothing to do with dyn channels. A "dyn channel" is a
concept that never reaches the firmware/phy level.

If a dyn channel is set to PDCH mode, the TS is configured
*exactly* like a plain PDCH. I.e. it *is* configured as
GsmL1_LogChComb_XIII.

The point why I'm talking about dyn TS is because a PDCH failure
messes up the higher level. But otherwise, this issue is about *plain*
PDCH. Let's drop dyn TS from the technical discussion entirely.

Please fix the SAPI activation for *plain* PDCH, which will as
a side effect fix the dyn TS state.

My point here is that by including PTCCH UL in pdtch_sapis[], you have enabled a feature
that is not yet mature and is actually breaking another feature, for no known benefit.
I would like to take back the immature feature for the benefit of the working one.

A possible fix for PTCCH UL might be at these places:

osmo-pcu/src/osmo-bts-sysmo/sysmo_l1_if.c:143:  case GsmL1_Sapi_Ptcch:
osmo-pcu/src/osmo-bts-sysmo/sysmo_l1_if.c-144-          // FIXME

osmo-pcu/src/osmo-bts-sysmo/sysmo_l1_if.c:207:  case GsmL1_Sapi_Ptcch:
osmo-pcu/src/osmo-bts-sysmo/sysmo_l1_if.c-208-          // FIXME

osmo-pcu/src/pcu_l1_if.cpp:295: case PCU_IF_SAPI_PTCCH:
osmo-pcu/src/pcu_l1_if.cpp-296-         /* FIXME */

But the point remains that enabling PTCCH UL makes no sense right now.

-- 
To view, visit https://gerrit.osmocom.org/671
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia59d95c75a8a5d3bd596f55cd1dc0906a6a95f7f
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: neels_test_account <neels at hofmeyr.de>
Gerrit-HasComments: No



More information about the gerrit-log mailing list