osmo-pcu[master]: Modify EGPRS DL TBF flow to support SPB

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

arvind.sirsikar gerrit-no-reply at lists.osmocom.org
Wed Aug 10 10:58:31 UTC 2016


Patch Set 10:

(3 comments)

https://gerrit.osmocom.org/#/c/655/6/src/pcu_vty.c
File src/pcu_vty.c:

PS6, Line 133: p
> why are you putting a space before the end-of-line?  Which part of the code
Done


PS6, Line 490: DL SPB suppor
> * why is there a second optional argument that is not used in the code?
Done


Line 493: 	struct gprs_rlcmac_bts *bts = bts_main_data();
> have you seen this syntax/description for help used anywhere else in the co
Done


-- 
To view, visit https://gerrit.osmocom.org/655
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I242afdd8ae7622dec8593b26382ad66bad5b9516
Gerrit-PatchSet: 10
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list