[PATCH] osmo-bts[master]: sysmo: fix dyn TS: Revert "Activate PTCCH UL" [in sysmobts]

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Aug 9 18:47:35 UTC 2016


Review at  https://gerrit.osmocom.org/671

sysmo: fix dyn TS: Revert "Activate PTCCH UL" [in sysmobts]

This reverts commit 53d792c3b027bfb42d77804e3e687a287e122ef3.
The commit caused this error with SysmoBTS:

DL1P <0007> l1_if.c:164 Tx L1 prim MPH-ACTIVATE.req
DL1C <0006> oml.c:811 Error activating L1 SAPI PTCCH on TS 7: Invalid parameter
DL1C <0006> oml.c:1089 (bts=0,trx=0,ts=7,ss=0) act failed mark broken due status: -4

Since dynamic timeslots wait for the activation to succeed, the broken status
breaks dynamic timeslots on SysmoBTS. Initially GPRS works, but the state in
the BSC is messed up and placing calls fails for dyn TS:

DRLL <0000> chan_alloc.c:355 Failed to allocate TCH_H channel
DRSL <0004> abis_rsl.c:1656 BTS 0 CHAN RQD: no resources for TCH_H 0x45

Normal PDCH on SysmoBTS was not broken -- the error message occurs, but that
doesn't seem to matter much. Plain GPRS still works since there is no
switchover involved. But I can see no benefit in enabling PTCCH UL on sysmo.

Since the commit only enabled PTCCH UL in sysmobts, no other BTS models are
affected. Notice that lc15 still has PTCCH UL disabled all the while, before
and after this commit and its revert.

Change-Id: Ia59d95c75a8a5d3bd596f55cd1dc0906a6a95f7f
---
M src/osmo-bts-sysmo/oml.c
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/71/671/1

diff --git a/src/osmo-bts-sysmo/oml.c b/src/osmo-bts-sysmo/oml.c
index e9a4794..585e6d0 100644
--- a/src/osmo-bts-sysmo/oml.c
+++ b/src/osmo-bts-sysmo/oml.c
@@ -617,9 +617,8 @@
 	{ GsmL1_Sapi_Pdtch,	GsmL1_Dir_RxUplink },
 	{ GsmL1_Sapi_Ptcch,	GsmL1_Dir_TxDownlink },
 	{ GsmL1_Sapi_Prach,	GsmL1_Dir_RxUplink },
-	{ GsmL1_Sapi_Ptcch,	GsmL1_Dir_RxUplink },
-	/* FIXME: do we still need this if? */
 #if 0
+	{ GsmL1_Sapi_Ptcch,	GsmL1_Dir_RxUplink },
 	{ GsmL1_Sapi_Pacch,	GsmL1_Dir_TxDownlink },
 #endif
 };

-- 
To view, visit https://gerrit.osmocom.org/671
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia59d95c75a8a5d3bd596f55cd1dc0906a6a95f7f
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: neels_test_account <neels at hofmeyr.de>



More information about the gerrit-log mailing list