openbsc[master]: gsm_pchan2chan_nr: disable a chan_nr assert, to not break oc...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Aug 9 10:46:56 UTC 2016


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/665/1/openbsc/src/libcommon/gsm_data_shared.c
File openbsc/src/libcommon/gsm_data_shared.c:

Line 599: 		OSMO_ASSERT(lchan_nr == 0);
> either remove it completely or check for 0 || 4.  As far as I remember, 0 a
To fix the regression introduced by this assertion,
I'd just drop it for now until we have time to properly check on it.
The point is that this needs to be clarified.

But ok, I guess I can ROLE_BSC it...


-- 
To view, visit https://gerrit.osmocom.org/665
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I05253343d5bcc7b319444376098dc8561dd83944
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: neels_test_account <neels at hofmeyr.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list