[PATCH] osmo-bts[master]: ci/spatch: Remove the "static" analysis handling

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Mon Aug 8 06:02:40 UTC 2016


Review at  https://gerrit.osmocom.org/656

ci/spatch: Remove the "static" analysis handling

spatch on Debian 8.0 has already crashed twice and is likely to
crash more and at the same time the value for this static checking
is close to zero (nice idea but never blossomed). So let's remove
it, have a more reliable build and let's coverity find those issues.

Change-Id: Ic1004edf7f0bee8dda30b95554a0aaf0b116b6b8
---
M contrib/jenkins_oct.sh
M contrib/jenkins_sysmobts.sh
2 files changed, 0 insertions(+), 28 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/56/656/1

diff --git a/contrib/jenkins_oct.sh b/contrib/jenkins_oct.sh
index 3489297..88b8c08 100755
--- a/contrib/jenkins_oct.sh
+++ b/contrib/jenkins_oct.sh
@@ -15,9 +15,6 @@
 # Build the dependency
 cd ../
 
-# Analysis code
-osmo-deps.sh osmo-static-analysis
-
 osmo-deps.sh libosmocore
 cd libosmocore
 autoreconf --install --force
@@ -54,15 +51,3 @@
 PKG_CONFIG_PATH=$PWD/deps/install/lib/pkgconfig $MAKE $PARALLEL_MAKE
 PKG_CONFIG_PATH=$PWD/deps/install/lib/pkgconfig LD_LIBRARY_PATH=$PWD/deps/install/lib $MAKE check
 DISTCHECK_CONFIGURE_FLAGS="--with-octsdr-2g=$PWD/deps/layer1-api/ --with-openbsc=$PWD/deps/openbsc/openbsc/include" PKG_CONFIG_PATH=$PWD/deps/install/lib/pkgconfig LD_LIBRARY_PATH=$PWD/deps/install/lib $MAKE distcheck
-
-
-
-# Use spatch to find common issues
-spatch -include_headers -in_place -sp_file deps/osmo-static-analysis/coccinelle/memcpy.cocci .
-RES=`git status --porcelain | grep ' M' | wc -l`
-git checkout .
-
-if [ $RES -gt 0 ]; then
-   echo "Static analysis failed. Please fix the code."
-   exit 23
-fi 
diff --git a/contrib/jenkins_sysmobts.sh b/contrib/jenkins_sysmobts.sh
index 7d171fc..051c8e0 100755
--- a/contrib/jenkins_sysmobts.sh
+++ b/contrib/jenkins_sysmobts.sh
@@ -15,9 +15,6 @@
 # Build the dependency
 cd ../
 
-# Analysis code
-osmo-deps.sh osmo-static-analysis
-
 osmo-deps.sh libosmocore
 cd libosmocore
 autoreconf --install --force
@@ -62,13 +59,3 @@
 if [ $FIRMWARE_VERSION != "femtobts_v2.7" ]; then
   PKG_CONFIG_PATH=$PWD/deps/install/lib/pkgconfig $MAKE -C contrib/sysmobts-calib
 fi
-
-# Use spatch to find common issues
-spatch -include_headers -in_place -sp_file deps/osmo-static-analysis/coccinelle/memcpy.cocci .
-RES=`git status --porcelain | grep ' M' | wc -l`
-git checkout .
-
-if [ $RES -gt 0 ]; then
-   echo "Static analysis failed. Please fix the code."
-   exit 23
-fi 

-- 
To view, visit https://gerrit.osmocom.org/656
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic1004edf7f0bee8dda30b95554a0aaf0b116b6b8
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Holger Freyther <holger at freyther.de>



More information about the gerrit-log mailing list