openbsc[master]: V42BIS integration

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Aug 4 15:05:10 UTC 2016


Patch Set 9: Code-Review-1

(3 comments)

https://gerrit.osmocom.org/#/c/644/9//COMMIT_MSG
Commit Message:

Line 10: edited to fit our needs
a quick summary would be good.


https://gerrit.osmocom.org/#/c/644/9/openbsc/include/openbsc/debug.h
File openbsc/include/openbsc/debug.h:

Line 39: 	DSNDCP,
it moves DSNDCP, which is an unrelated change.


https://gerrit.osmocom.org/#/c/644/9/openbsc/src/gprs/v42bis.c
File openbsc/src/gprs/v42bis.c:

Line 79:  * without modification 
let's remove the Visual Studio and assembly related parts and keep the C language implementation.  Also, if we don't have it yet, it might be a good candidate for libosmocore 'bits.c'.


-- 
To view, visit https://gerrit.osmocom.org/644
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I689413f2541b6def0625ce6bd96f1f488f05f99d
Gerrit-PatchSet: 9
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list