This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 7: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/643/7//COMMIT_MSG Commit Message: PS7, Line 7: Added please don't use past tense. The commit message preceeds the comment, so the addition is currently happening or about to happen, but hasn't happened yet. PS7, Line 9: V42BIS V.42bis is the name of the spec, AFAIK. Of course that can't be used in #defines or for othe C language identifiers, but in human readable documentation the official name can be used. -- To view, visit https://gerrit.osmocom.org/643 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iabedece9f97ca944a1e3f747bb073e532c4e9dca Gerrit-PatchSet: 7 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-HasComments: Yes