osmo-bts[master]: Fill measurements data for L1SAP

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Aug 4 11:44:46 UTC 2016


Patch Set 4: Code-Review-1

(1 comment)

> I'm not sure if we need to bump BTS<->PCU version here - the change
 > is backward-compatible. Please advice.

In which way is it backwards-compatible?  Only an old PCU woul work with a new BTS, but not the other way around, right?  In that case, the version must be bumped.

https://gerrit.osmocom.org/#/c/623/4/include/osmo-bts/pcuif_proto.h
File include/osmo-bts/pcuif_proto.h:

Line 53: 	uint16_t ber10k;	/*!< \brief BER in units of 0.01% */
all previous struct members are tab-aligned, yours not?


-- 
To view, visit https://gerrit.osmocom.org/623
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9693a044756fb1c7bd2ff3cfa0db042c3c4e01c
Gerrit-PatchSet: 4
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list