This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
daniel gerrit-no-reply at lists.osmocom.org
Patch Set 1: Code-Review-1
(2 comments)
With your patch there is now a useless option (-i). Before the builtin id would be shadowed by options.id so it would still use that value as the id.
But yeah, the naming of the variables and parameters could be improved.
https://gerrit.osmocom.org/#/c/640/1/openbsc/contrib/bsc_control.py
File openbsc/contrib/bsc_control.py:
Line 39: def do_set(var, value, op_id, sck):
I agree, the name should change to avoid shadowing id and the parameter id was not used at all (but options.id directly).
Line 57: parser.add_option("-i", "--id", dest="id", default="1",
How about setting the random value as a default here? The this option does not become useless. Rename the option to something that is not a keyword/builtin as well (cmd_id?)
--
To view, visit https://gerrit.osmocom.org/640
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I87d9ee0e9a87f58702c60bb141c973d41fa06997
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-HasComments: Yes