<div dir="ltr"><div style="font-size:small" class="gmail_default"><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, May 16, 2018 at 3:38 PM, Neels Hofmeyr <span dir="ltr"><<a target="_blank" href="mailto:nhofmeyr@sysmocom.de">nhofmeyr@sysmocom.de</a>></span> wrote:<br><blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote"><span class="gmail-m_-1334466491590542135gmail-">On Wed, May 16, 2018 at 04:47:32AM +0300, Nikos Balkanas wrote:<br>
> I think I got it working. I got this cryptic response:<br>
> <br>
> -> git push ssh://osmo/osmocom-bb.git<br>
> Everything up-to-date<br>
<br>
</span>That is definitely not how to push a patch for review to gerrit.<br>
<br>
Look, you're the first to have trouble reading the wiki page on Gerrit<br>
submissions, I believe the information there is quite clear. If it isn't, then<br>
we should fix that. Let us know where we lose you.<br></blockquote><div><br><div style="font-size:small" class="gmail_default">Too much Information. Confusing. <br></div><div style="font-size:small" class="gmail_default">There should be only 3 headers aside from the introductory why you use gerrit:<br></div><div style="font-size:small" class="gmail_default">1) Creating user in gerrit<br></div><div style="font-size:small" class="gmail_default">2) Setting up gerrit for commits and pushing<br></div><div style="font-size:small" class="gmail_default">3) Push Patch for Review<br></div><div style="font-size:small" class="gmail_default"><br></div><div style="font-size:small" class="gmail_default">The only relevant entry in there is "Push for Review", and It is wrong:(<br><pre>git push gerrit HEAD:refs/for/master/my_topic
<br></pre><pre>It is different from what you told me in this mail, and gerrit is not an FQD.<br></pre><pre>When I try to use FQD for gerrit, I get pubkey errors:<br></pre>-> git push <a href="http://nbalkanas@gerrit.osmocom.org:29418">nbalkanas@gerrit.osmocom.org:29418</a> HEAD:refs/for/master/Minor_Typo_Fixes<br>Permission denied (publickey).<br></div>fatal: Could not read from remote repository.<br><br></div><blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote">
If you still can't get it to work, please show us your ~/.ssh/config that you<br>
apparently use, share the state your git clone is in and your complete<br>
commandline and output that you use to push the patch.<br>
<span class="gmail-m_-1334466491590542135gmail-"><br></span></blockquote><div>-<div style="font-size:small;display:inline" class="gmail_default">> cat .ssh/config<br><br>ServerAliveInterval = 300<br>Host osmo<br>Hostname <a target="_blank" href="http://gerrit.osmocom.org">gerrit.osmocom.org</a><br>Port 29418<br>User nbalkanas<br><br></div><div style="font-size:small;display:inline" class="gmail_default">-> git status<br><br></div><div style="font-size:small;display:inline" class="gmail_default">On branch master<br>Your branch is up-to-date with 'origin/master'.<br><br>Changes not staged for commit:<br> (use "git add <file>..." to update what will be committed)<br> (use "git checkout -- <file>..." to discard changes in working directory)<br><br> modified: src/README.building<br><br>no changes added to commit (use "git add" and/or "git commit -a")<br><br></div><div style="font-size:small" class="gmail_default">-> git add src/README.building<br></div><div style="font-size:small" class="gmail_default">-> git add -f src/shared/libosmocore/<wbr>configure<br>-> git push ssh://osmo/osmocom-bb.git<br><br>Everything up-to-date<br></div><br> <div class="gmail_default" style="font-size:small;display:inline"><br></div></div><blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote"><span class="gmail-m_-1334466491590542135gmail-">
> Anyway to check if changes committed?<br>
> Cloning from gerrit will just give me the main osmocom-bb.git :(<br>
<br>
</span>You are merely allowed to push a patch for review. Cloning osmocom-bb.git will<br>
only contain your patch if we approved and merged it. Usually that takes a<br>
couple of review iterations on <a target="_blank" rel="noreferrer" href="http://gerrit.osmocom.org">gerrit.osmocom.org</a> first.<br>
<br></blockquote><div><div class="gmail_default" style="font-size:small"><br>That's a major shortcoming. CVS has its problems but at least you can check what you have just commited:(</div> </div><blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote">
You have created a user on <a target="_blank" rel="noreferrer" href="http://gerrit.osmocom.org">gerrit.osmocom.org</a>?<br></blockquote><div> </div><div class="gmail_default" style="font-size:small">Yes, I created user and added public key. Otherwise I would keep getting:<br><br>Permission denied (publickey).<br>fatal: Could not read from remote repository.<br><br>Please make sure you have the correct access rights<br>and the repository exists.<br><br></div><blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote">
<span class="gmail-m_-1334466491590542135gmail-HOEnZb"><font color="#888888"><br>
~N<br>
</font></span></blockquote></div><br></div></div>