From d1ad22fa60= e9d52bac246391b2fb6de57fb067b7 Mon Sep 17 00:00:00 2001

From: Bhaskar <niceguy108 at gmail.com>

Date: Wed, 22 May 2013 13:08:02 = +0530

Subject: [PATC= H] * Bugfix in Firmware: initialising variables

Under specific circ= umstances, these variables would have been used without initialisation.

<= font face=3D"courier new, monospace">---

=A0src/target/firmware/apps/load= er/main.c =A0 =A0| =A0 =A02 +-

=A0src/target/firmware/layer1/mframe_sched.c | =A0 =A02 +-

=A02 files changed, 2 ins= ertions(+), 2 deletions(-)

diff --git a/src/target/firmware/apps/loader/ma= in.c b/src/target/firmware/apps/loader/main.c

index 8bdbc74..c74c045 100644

--- a/src/target/firmware/apps/l= oader/main.c

+++ b/s= rc/target/firmware/apps/loader/main.c

@@ -213,7 +213,7 @@ static void cmd_handler(uint8_t dlci,= struct msgb *msg)

=A0

=A0 = uint8_t command =3D msgb_pull_u8(msg);

=A0

- int res;

+ int res =3D 0;=

=A0

=A0 = flash_lock_t lock;

=A0

diff --git a/src/target/firmware= /layer1/mframe_sched.c b/src/target/firmware/layer1/mframe_sched.c

index f3a6b43..047d709 10064= 4

--- a/src/target/firmware/layer1= /mframe_sched.c

+++ = b/src/target/firmware/layer1/mframe_sched.c

@@ -343,7 +343,7 @@ static const struct mframe_sche= d_item *sched_set_for_task[32] =3D {

=A0/* encodes a channel number a= ccording to 08.58 Chapter 9.3.1 */

=A0uint8_t mframe_task2chan_nr(enum mframe_task mft, uint8_t= ts)

=A0{

- uint8_t cbits;

= + uint8_t cbits =3D 0;

=A0

=A0 = switch (mft) {

case MF_TASK_BCCH_N= ORM:

--=A0

1.7.9

--047d7bdc15d456c2b204dd61e109-- From niceguy108 at gmail.com Thu May 23 12:35:02 2013 From: niceguy108 at gmail.com (Bhaskar11) Date: Thu, 23 May 2013 18:05:02 +0530 Subject: [PATCH] * Bugfix in Firmware: initialising variables In-Reply-To: References: Message-ID: Including Patch file just in case. B. On Thu, May 23, 2013 at 6:02 PM, Bhaskar11 wrote: > From d1ad22fa60e9d52bac246391b2fb6de57fb067b7 Mon Sep 17 00:00:00 2001 > From: Bhaskar > Date: Wed, 22 May 2013 13:08:02 +0530 > Subject: [PATCH] * Bugfix in Firmware: initialising variables > > Under specific circumstances, these variables would have been used without > initialisation. > > --- > src/target/firmware/apps/loader/main.c | 2 +- > src/target/firmware/layer1/mframe_sched.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/target/firmware/apps/loader/main.c > b/src/target/firmware/apps/loader/main.c > index 8bdbc74..c74c045 100644 > --- a/src/target/firmware/apps/loader/main.c > +++ b/src/target/firmware/apps/loader/main.c > @@ -213,7 +213,7 @@ static void cmd_handler(uint8_t dlci, struct msgb *msg) > > uint8_t command = msgb_pull_u8(msg); > > - int res; > + int res = 0; > > flash_lock_t lock; > > diff --git a/src/target/firmware/layer1/mframe_sched.c > b/src/target/firmware/layer1/mframe_sched.c > index f3a6b43..047d709 100644 > --- a/src/target/firmware/layer1/mframe_sched.c > +++ b/src/target/firmware/layer1/mframe_sched.c > @@ -343,7 +343,7 @@ static const struct mframe_sched_item > *sched_set_for_task[32] = { > /* encodes a channel number according to 08.58 Chapter 9.3.1 */ > uint8_t mframe_task2chan_nr(enum mframe_task mft, uint8_t ts) > { > - uint8_t cbits; > + uint8_t cbits = 0; > > switch (mft) { > case MF_TASK_BCCH_NORM: > -- > 1.7.9 > > -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-Bugfix-in-Firmware-initialised-variables.patch Type: application/octet-stream Size: 1422 bytes Desc: not available URL: From niceguy108 at gmail.com Tue May 28 06:54:11 2013 From: niceguy108 at gmail.com (Bhaskar11) Date: Tue, 28 May 2013 12:24:11 +0530 Subject: [PATCH] * Bugfix in Firmware: initialising variables In-Reply-To: References: Message-ID: Please let me know if this email format patch worked ok. I have a few more patches that I'm waiting to send. B. On Thu, May 23, 2013 at 6:02 PM, Bhaskar11 wrote: > From d1ad22fa60e9d52bac246391b2fb6de57fb067b7 Mon Sep 17 00:00:00 2001 > From: Bhaskar > Date: Wed, 22 May 2013 13:08:02 +0530 > Subject: [PATCH] * Bugfix in Firmware: initialising variables > > Under specific circumstances, these variables would have been used without > initialisation. > > --- > src/target/firmware/apps/loader/main.c | 2 +- > src/target/firmware/layer1/mframe_sched.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/target/firmware/apps/loader/main.c > b/src/target/firmware/apps/loader/main.c > index 8bdbc74..c74c045 100644 > --- a/src/target/firmware/apps/loader/main.c > +++ b/src/target/firmware/apps/loader/main.c > @@ -213,7 +213,7 @@ static void cmd_handler(uint8_t dlci, struct msgb *msg) > > uint8_t command = msgb_pull_u8(msg); > > - int res; > + int res = 0; > > flash_lock_t lock; > > diff --git a/src/target/firmware/layer1/mframe_sched.c > b/src/target/firmware/layer1/mframe_sched.c > index f3a6b43..047d709 100644 > --- a/src/target/firmware/layer1/mframe_sched.c > +++ b/src/target/firmware/layer1/mframe_sched.c > @@ -343,7 +343,7 @@ static const struct mframe_sched_item > *sched_set_for_task[32] = { > /* encodes a channel number according to 08.58 Chapter 9.3.1 */ > uint8_t mframe_task2chan_nr(enum mframe_task mft, uint8_t ts) > { > - uint8_t cbits; > + uint8_t cbits = 0; > > switch (mft) { > case MF_TASK_BCCH_NORM: > -- > 1.7.9 > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From 246tnt at gmail.com Tue May 28 07:48:41 2013 From: 246tnt at gmail.com (Sylvain Munaut) Date: Tue, 28 May 2013 09:48:41 +0200 Subject: [PATCH] * Bugfix in Firmware: initialising variables In-Reply-To: References:

Message-ID: Please learn to use git-sendemail and posts all the patch at once in a series because I'm spending more time trying to figure out which patch I've applied than actually reviewing them. And the patch you tried to include inline manually above is completely mangled and un-usable. Cheers, Sylvain From niceguy108 at gmail.com Thu May 23 12:49:57 2013 From: niceguy108 at gmail.com (Bhaskar11) Date: Thu, 23 May 2013 18:19:57 +0530 Subject: flashing problem fixed Message-ID: The two patches I have posted (separately) relating to "msgb_pull" use in Osmocom and firmware are required to fix the flashing problem! With these patches, I am able to use all the flash functions now. I still need to load the file "loader.e88loader.bin" which does not appear in my compile, as mentioned in a separate email. I bricked a phone by aborting the flashing at that stage! :-( Any advice on this will be appreciated. B. On Thu, May 23, 2013 at 5:51 PM, Akib Sayyed wrote: > bhaskar > > Have you solved issue with flashing. > > > On Thu, May 23, 2013 at 4:44 PM, Bhaskar11 wrote: > >> Patched in format according to guidelines. >> >> B. >> >> > > > -- > Akib Sayyed > Matrix-Shell > akibsayyed at gmail.com > akibsayyed at matrixshell.com > Mob:- +91-966-514-2243 > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From altaf329 at gmail.com Mon May 27 07:24:15 2013 From: altaf329 at gmail.com (Altaf) Date: Mon, 27 May 2013 00:24:15 -0700 (PDT) Subject: Suggestions required to implement Calypso BTS with GPRS (minimal) Message-ID: <1369639455404-4026049.post@n3.nabble.com> I have been successful in running the calypso BTS and registering phones to it. I have also examined the source code implemented. I am currently doing an Internship in Berlin and the company wants to demonstrate to it customers that 2G services are not secure. Basically we are designing a securtiy demonstrator. We want to do man-in-the-middle attacks with the existing open source s/w. So we thought a B100 USrp would be the need of the hour. But I am really interested working with the calypso phones because I am comfortable with the source code and have already worked on it. I want to try (do) implementing the GPRS functionality to this calypso BTS. Since the work is mostly involved at Layer1 or lets say transceiver. I tried running OpenBTS-gprs version and resulted with some info. The mframe_sched in the trx doesnt contain info about the how to handle packet channels or the multiframes do not have the Packet channels. So when the BTS assigns (on CCCH) a dedicated channel and the calypso phone fails to receive uplink or doesnt provide a way for the phone to access the BTS. I understand the working of trx and want to add this GPRS functionality to trx. I am aiming to implement minimal GPRS functionality. I have also seen how OpenBTS-gprs has triggers this packet channel or the way multiframes handle PDCH, PTCH.. By observing them I can get some idea. In this regard I request from you few suggestions such as where I have to work more and what are the challenges I will face. your suggestions are valuable to me. -- View this message in context: http://baseband-devel.722152.n3.nabble.com/Suggestions-required-to-implement-Calypso-BTS-with-GPRS-minimal-tp4026049.html Sent from the baseband-devel mailing list archive at Nabble.com.