[PATCH 1/2] comm: msgb: don't set backlight on error
laforge at gnumonks.org
Mon May 2 09:15:26 CEST 2011
On Sun, May 01, 2011 at 10:18:04AM +0200, Wolfram Sang wrote:
> This, I understand, it blinks. But it was changed three days later
> to the current state (c917fd43797c30385a1ba860fef95be97c84d51d)
> which broke it ('i' is constant now). So it is broken for over a
> year and nobody noticed :)
Well, let's say we noticed that we get layer1 panics without any indication.
> So, instead of introducing a board_panic which nobody seems to need, I'd just
> suggest using plain osmo_panic as in other places. Much cleaner, too, IMO.
I disagree. We desperately need board_panic, (with much more than just
backlight blinking in the future), to be able to solve the various mysterious
layer1/firmware crashes that we're seeing more or less all the time.
I had recently discussed this with Andreas and Sylvain at the Easterhegg,
and they both agreed that we need a way to debug crashes better. We need
to tap into the various exception handlers, we need to use the debug unit
to get backtraces, and we need ways like backlight blinking or buzzer sounds
that can be done from a few lines of stack-independent assembly code to
reliably indicate what has happened to the system.
- Harald Welte <laforge at gnumonks.org> http://laforge.gnumonks.org/
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)
More information about the baseband-devel