10 Nov
2015
10 Nov
'15
11:56 a.m.
Hi,
I am working on getting libosmocom package into Fedora, there is
review request in [1].
During the packaging I found following minor issues:
- Incorrect FSF addresses in source code, e.g. there is written in the
sources:
59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
But the correct address is (as taken from the
https://www.gnu.org/licenses/gpl-2.0.html):
51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA
- exit call in the library: /usr/lib64/libosmovty.so.3.0.0 exit(a)GLIBC_2.2.5
libraries shouldn't generally call exit.
thanks & regards
Jaroslav
[1] https://bugzilla.redhat.com/show_bug.cgi?id=1279527
10 Nov
10 Nov
9:48 p.m.
Hi Jaroslav,
On Tue, Nov 10, 2015 at 04:56:23AM -0500, Jaroslav Skarvada wrote:
I am working on getting libosmocom package into
Fedora, there is
review request in [1].
Thanks for this!
During the packaging I found following minor issues:
- Incorrect FSF addresses in source code
This is easy to fix. Do you already have a patch to fix all
occurrences? I'd happily apply that.
- exit call in the library:
/usr/lib64/libosmovty.so.3.0.0 exit(a)GLIBC_2.2.5
libraries shouldn't generally call exit.
libosmovty started as a fork of the VTY (telnet command line interface)
code of GNU zebra. So the code was not written as a library to begin
with, but was part of zebra itself.
In any case, addressing those issues is not particularly easy, as said
functions should never fail at this point, but they don't have a way to
return an error code, or their callers simply assume they always
succeed.
So the best we can do without breaking API and ABI (and modifying all
users of the library) is to change the exit(1) calls into an assert.
Would that be better?
--
- Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)
11 Nov
11 Nov
5:23 p.m.
----- Original Message -----
Nice, thanks. Please note, this is not something that blocks Fedora
review, I just wanted to point it out, e.g. to consider it for
next API update sometimes in the future
thanks & regards
Jaroslav
Hi Jaroslav,
On Tue, Nov 10, 2015 at 04:56:23AM -0500, Jaroslav Skarvada wrote:
Patch attempting to fix it is attached.
I am working on getting libosmocom package into
Fedora, there is
review request in [1].
Thanks for this!
During the packaging I found following minor
issues:
- Incorrect FSF addresses in source code
This is easy to fix. Do you already have a patch to fix all
occurrences? I'd happily apply that.
- exit call in
the library: /usr/lib64/libosmovty.so.3.0.0 exit(a)GLIBC_2.2.5
libraries shouldn't generally call exit.
libosmovty started as a fork of the VTY (telnet command line interface)
code of GNU zebra. So the code was not written as a library to begin
with, but was part of zebra itself.
In any case, addressing those issues is not particularly easy, as said
functions should never fail at this point, but they don't have a way to
return an error code, or their callers simply assume they always
succeed.
So the best we can do without breaking API and ABI (and modifying all
users of the library) is to change the exit(1) calls into an assert.
Would that be better?
12 Nov
12 Nov
2:50 p.m.
Hi Jaroslav,
On Wed, Nov 11, 2015 at 10:23:11AM -0500, Jaroslav Skarvada wrote:
Patch attempting to fix it is
attached.
Patch applied, thanks.
Nice, thanks. Please note, this is not something that blocks Fedora
review, I just wanted to point it out, e.g. to consider it for
next API update sometimes in the future
Thanks. I've just applied a patch to change the exit() calls into
OSMO_ASSERT() instead, which is a better and more generic way to do this
anyway.
The VTY code doesn't get much love from us, we simply adapted it from
Zebra back in the early days of OpenBSC, and it sits there without much
review/improvement/change.
Regards,
Harald
--
- Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)
During the packaging I found following minor issues:
- Incorrect FSF addresses in source code
- exit call in the library:
/usr/lib64/libosmovty.so.3.0.0 exit(a)GLIBC_2.2.5
libraries shouldn't generally call exit.
So the best we can do without breaking API and ABI (and modifying all
users of the library) is to change the exit(1) calls into an assert.
Would that be better? 
4:05 p.m.
12.11.2015 13:50, Harald Welte пишет:
The VTY code doesn't get much love from us, we simply adapted it from
Zebra back in the early days of OpenBSC, and it sits there without much
review/improvement/change.
Speaking of which - upstream (quagga, successor to zebra) would welcome if anyone
could abstract their vty code and split it into separate library.
See https://bugzilla.quagga.net/show_bug.cgi?id=847 for details.
cheers,
Max.
3124
days inactive
3126
days old
4 comments
3 participants
participants (3)
-
Harald Welte -
Jaroslav Skarvada -
Suraev